Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: do not apply long dependent tests to all versions #178787

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jul 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Not that common for versioned formulae to have sufficient dependents to need this label, e.g. node@*, gcc@*

@cho-m cho-m requested review from MikeMcQuaid and a team as code owners July 28, 2024 18:59
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Jul 28, 2024
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 29, 2024
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

Merged via the queue into master with commit 8e74949 Jul 29, 2024
19 checks passed
@MikeMcQuaid MikeMcQuaid deleted the triage-versioned-dep-test branch July 29, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants